Conversation
| } | ||
| } | ||
|
|
||
| for _, executionResult := range obh.Header.GetExecutionResultsHandlers() { |
There was a problem hiding this comment.
don't we need to check if header v3 here?
There was a problem hiding this comment.
no, if is HeaderV1 or HeaverV2 it will return nil and will not go in the for loop
| executionResult.AccumulatedFees = t.AccumulatedFees.String() | ||
| executionResult.DeveloperFees = t.DeveloperFees.String() |
There was a problem hiding this comment.
do we need these for shard exec result?
There was a problem hiding this comment.
Yes, because also on the shard block are indexed
| Round: obh.Header.GetRound(), | ||
| ShardID: obh.Header.GetShardID(), | ||
| Epoch: obh.Header.GetEpoch(), | ||
| MiniBlockHeaders: obh.Header.GetMiniBlockHeaderHandlers(), |
There was a problem hiding this comment.
so here we index proposed miniblocks? and below we index executed miniblocks, right?
| ) | ||
| } | ||
|
|
||
| // RemoveMiniblocks will remove all miniblocks that are in header from elasticsearch server |
There was a problem hiding this comment.
is the flow on remove updated also for miniblocks?
There was a problem hiding this comment.
is GetMiniblocksHashesHexEncoded properly updated to fetch miniblocks from execution results?
There was a problem hiding this comment.
refactored this method
| func (ei *elasticProcessor) RemoveTransactions(header coreData.HeaderHandler, body *block.Body, timestampMs uint64) error { | ||
| encodedTxsHashes, encodedScrsHashes := ei.transactionsProc.GetHexEncodedHashesForRemove(header, body) | ||
| headerData := &data.HeaderData{ | ||
| Timestamp: header.GetTimeStamp(), | ||
| TimestampMs: timestampMs, | ||
| Round: header.GetRound(), | ||
| ShardID: header.GetShardID(), | ||
| Epoch: header.GetEpoch(), | ||
| MiniBlockHeaders: header.GetMiniBlockHeaderHandlers(), | ||
| } | ||
| encodedTxsHashes, encodedScrsHashes := ei.transactionsProc.GetHexEncodedHashesForRemove(headerData, body) |
There was a problem hiding this comment.
do we have to remove also the txs from execution results?
There was a problem hiding this comment.
starting with header v3 we should not have rollbacks.
| } | ||
| } | ||
|
|
||
| for _, executionResult := range obh.Header.GetExecutionResultsHandlers() { |
process/elasticproc/transactions/smartContractResultsProcessor.go
Outdated
Show resolved
Hide resolved
3 participants
Uh oh!
There was an error while loading. Please reload this page.